Use tabs for details pane #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to distinguish more from the diagram/table seems like all diagram apps use a different color for their panes. I think it makes sense.
this seems like a good place for misc things to live. makes notes feel more at-home/organized, and the graph part feels better isolated as a header of the details. included node-type-specific details in "basics" as well - maybe ideal to have another section for these, but they aren't used very often, so it seems ok. also remove "problem node"/"addresses edge" text; seemed unnecessary.
so that sections can alternatively be headered by tabs
seems a little easier to consume, especially if new to the UI. can see how it feels. included an "expandDetailsTabs" user config to easily revert in case that seems useful. I expect adding details will prefer having tabs expanded, since you'll be adding different kinds of details as you think of them.
✅ Deploy Preview for velvety-vacherin-4193fb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ameliorate-docs canceled.
|
|
This makes the ontology topic not show justification/research anymore in its default view. I think that's ok, but we should have a way to share a Topic with a specific diagram part's details tab selected, e.g. to specifically show a part's Questions. Created #608 for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #298
Description of changes
Additional context